Add support for variable interpolation to hcp_packer_registry and build blocks. #11421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azr
reviewed
Nov 30, 2021
| @@ -48,7 +48,7 @@ func (p *Parser) decodeHCPRegistry(block *hcl.Block) (*HCPPackerRegistryBlock, h | |||
| BuildLabels map[string]string `hcl:"build_labels,optional"` | |||
| Config hcl.Body `hcl:",remain"` | |||
| } | |||
| diags := gohcl.DecodeBody(body, nil, &b) | |||
| diags := gohcl.DecodeBody(body, cfg.EvalContext(BuildContext, nil), &b) | |||
There was a problem hiding this comment.
That's what I would've done ! 👍🏼
nywilken
force-pushed
the
hcp_packer_registry-variable-interpolation
branch
from
9bea722
to
8192c14
Compare
nywilken
force-pushed
the
hcp_packer_registry-variable-interpolation
branch
from
8192c14
to
d14649d
Compare
nywilken
changed the title
hcp_packer_registry block
nywilken
force-pushed
the
hcp_packer_registry-variable-interpolation
branch
from
8175f5c
to
996cc9a
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows for the use of variables for setting HCP Packer metadata.
Users should be able to set variables either statically or dynamically via environment variables to set bucket_name, bucket_labels, and build_labels.
This change adds support for using variables within the base Packer build block - merged in from Add build block variable interpolation #11425
Closes #9794
Closes https://github.com/hashicorp/packer-internal-issues/issues/20