prevent duplicate local block creation #11534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azr
force-pushed
the
azr/fix-duplicate-local-block
branch
from
732cc86
to
a2478c4
Compare
azr
force-pushed
the
azr/fix-duplicate-local-block
branch
from
a2478c4
to
e003e0c
Compare
azr
force-pushed
the
azr/fix-duplicate-local-block
branch
from
e003e0c
to
3239a7e
Compare
azr
force-pushed
the
azr/fix-duplicate-local-block
branch
from
3239a7e
to
c78e61c
Compare
azr
force-pushed
the
azr/fix-duplicate-local-block
branch
from
c78e61c
to
4405269
Compare
azr
commented
Jan 28, 2022
| func (c *PackerConfig) parseLocalVariables(f *hcl.File) ([]*LocalBlock, hcl.Diagnostics) { | ||
| // parseLocalVariableBlocks looks in the AST for 'local' and 'locals' blocks and | ||
| // returns them all. | ||
| func parseLocalVariableBlocks(f *hcl.File) ([]*LocalBlock, hcl.Diagnostics) { |
There was a problem hiding this comment.
I removed the PackerConfig, so that this function is only an extraction function.
azr
commented
Jan 28, 2022
|
|
||
| // divide by 2 so that you don't get duplicate locals | ||
| // appear to have double locals in LocalBlock, not sure if intentional | ||
| for i := 0; i < len(locals)/2; i++ { |
There was a problem hiding this comment.
This was not always correct
nywilken
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
Nice catch! This looks good. Test results below
Example HCL
~> cat /tmp/source.pkr.hcl
locals {
timestamp = formatdate("YYYY-MM-DD", timestamp())
other_local = "test-${local.timestamp}"
}
locals {
other_local = "testagain-${local.timestamp}"
}With Packer 1.7.9
~> ~/Downloads/packer179 validate /tmp/source.pkr.hcl
The configuration is valid.
With Dev Build
~> packer validate /tmp/source.pkr.hcl
Error: Duplicate local definition
on /tmp/source.pkr.hcl line 7:
(source code not available)
Duplicate other_local definition found.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #11527
A bug was introduced in #10509 where a local block could be parsed and added to the list n * n times. ( n being the number of local blocks defined per file ).
This makes sure these are only parsed once by:
localandlocalsblocks