Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder/virtualbox-ovf,vmware-vmx: add boot_command support #1169

Merged
merged 2 commits into from
Sep 5, 2014
Merged

builder/virtualbox-ovf,vmware-vmx: add boot_command support #1169

merged 2 commits into from
Sep 5, 2014

Conversation

rasa
Copy link
Collaborator

@rasa rasa commented May 13, 2014

Fixes #1082

@rickard-von-essen
Copy link
Collaborator

@rasa can you also add the Boot Command section from virtualbox-iso.html.markdown to the virtualbox-ovf.html.markdown.

@hoshposh
Copy link

Will this be merged soon? It appears to have the doc that @rickard-von-essen asked for.

@rasa
Copy link
Collaborator Author

rasa commented May 31, 2014

It's scheduled to be included in the next release.

@routelastresort
Copy link
Contributor

@rasa - every time I try boot commands (upon the first one entered, e.g. a carriage return), it will try to execute a VBoxManage poweroff and unregister, and crash (because it can't unregister a locked VM). It never tries to execute any boot commands. Do you have a working environment and/or example template?

EDIT: this happens to me w/vmware-vmx as well

@routelastresort
Copy link
Contributor

It looks like step_http_server needs to also be moved to common (after spending a ton of time with this) :)

panic: interface conversion: interface is nil, not uint
2014/07/07 05:21:01 /usr/local/bin/packer-builder-virtualbox-ovf: 
2014/07/07 05:21:01 /usr/local/bin/packer-builder-virtualbox-ovf: goroutine 82 [running]:
2014/07/07 05:21:01 /usr/local/bin/packer-builder-virtualbox-ovf: runtime.panic(0x3a2de0, 0xc21017b8c0)
2014/07/07 05:21:01 /usr/local/bin/packer-builder-virtualbox-ovf:   /usr/local/Cellar/go/1.2.1/libexec/src/pkg/runtime/panic.c:266 +0xb6
2014/07/07 05:21:01 /usr/local/bin/packer-builder-virtualbox-ovf: github.com/mitchellh/packer/builder/virtualbox/common.(*StepTypeBootCommand).Run(0xc210136e40, 0xb17588, 0xc210136db0, 0x0)
2014/07/07 05:21:01 /usr/local/bin/packer-builder-virtualbox-ovf:   /Users/death/go/src/github.com/mitchellh/packer/builder/virtualbox/common/step_type_boot_command.go:40 +0xdf
2014/07/07 05:21:01 /usr/local/bin/packer-builder-virtualbox-ovf: github.com/mitchellh/multistep.(*BasicRunner).Run(0xc21013a340, 0xb17588, 0xc210136db0)
2014/07/07 05:21:01 /usr/local/bin/packer-builder-virtualbox-ovf:   /Users/death/go/src/github.com/mitchellh/multistep/basic_runner.go:70 +0x341
2014/07/07 05:21:01 /usr/local/bin/packer-builder-virtualbox-ovf: github.com/mitchellh/packer/builder/virtualbox/ovf.(*Builder).Run(0xc210072000, 0xb170a8, 0xc2100f9e80, 0xb170f0, 0xc2100f8f20, ...)
2014/07/07 05:21:01 /usr/local/bin/packer-builder-virtualbox-ovf:   /Users/death/go/src/github.com/mitchellh/packer/builder/virtualbox/ovf/builder.go:131 +0xec9
2014/07/07 05:21:01 /usr/local/bin/packer-builder-virtualbox-ovf: github.com/mitchellh/packer/packer/rpc.(*BuilderServer).Run(0xc210072020, 0x1, 0xc2100b4d20, 0x0, 0x0)
2014/07/07 05:21:01 /usr/local/bin/packer-builder-virtualbox-ovf:   /Users/death/go/src/github.com/mitchellh/packer/packer/rpc/builder.go:93 +0x28b
2014/07/07 05:21:01 /usr/local/bin/packer-builder-virtualbox-ovf: reflect.Value.call(0x364220, 0x3c2450, 0x130, 0x418f00, 0x4, ...)
2014/07/07 05:21:01 /usr/local/bin/packer-builder-virtualbox-ovf:   /usr/local/Cellar/go/1.2.1/libexec/src/pkg/reflect/value.go:474 +0xe0b
2014/07/07 05:21:01 /usr/local/bin/packer-builder-virtualbox-ovf: reflect.Value.Call(0x364220, 0x3c2450, 0x130, 0x1a21ee8, 0x3, ...)
2014/07/07 05:21:01 /usr/local/bin/packer-builder-virtualbox-ovf:   /usr/local/Cellar/go/1.2.1/libexec/src/pkg/reflect/value.go:345 +0x9d
2014/07/07 05:21:01 /usr/local/bin/packer-builder-virtualbox-ovf: net/rpc.(*service).call(0xc21003f040, 0xc210054a40, 0xc2100b40a0, 0xc2100b6100, 0xc2100e91a0, ...)
2014/07/07 05:21:01 /usr/local/bin/packer-builder-virtualbox-ovf:   /usr/local/Cellar/go/1.2.1/libexec/src/pkg/net/rpc/server.go:381 +0x159
2014/07/07 05:21:01 /usr/local/bin/packer-builder-virtualbox-ovf: created by net/rpc.(*Server).ServeCodec
2014/07/07 05:21:01 /usr/local/bin/packer-builder-virtualbox-ovf:   /usr/local/Cellar/go/1.2.1/libexec/src/pkg/net/rpc/server.go:452 +0x3bb

@routelastresort
Copy link
Contributor

... and in vmware-vmx, the builder is lacking the VNC portion (which is used for boot commands)

@mitchellh
Copy link
Contributor

Looks great. I'm pulling this in. @routelastresort I'll take a look at those, thanks.

@mitchellh mitchellh merged commit e082a7e into hashicorp:master Sep 5, 2014
@mitchellh
Copy link
Contributor

@routelastresort I added HTTP server support to OVF. I'm fixing VMware now.

@routelastresort
Copy link
Contributor

Many thanks - your patches looked similar enough to my fork, but I'll go back and check!

@mitchellh
Copy link
Contributor

There seemed to be only one way to cook that turkey, so I'm sure they're pretty close.

@rasa rasa deleted the 1082-add-boot-commands-to-vmx-and-ovf-builders branch September 9, 2014 17:10
@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] boot commands for ovf source for vmware + virtualbox?
5 participants