Use the aws-sdk-go instance metadata client #2728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the instance metadata client originally introduced with the change from goamz to aws-sdk-go in favour of the one recently introduced to aws-sdk-go which supports retries.
| func (c *AccessConfig) Region() (string, error) { | ||
| if c.RawRegion != "" { |
There was a problem hiding this comment.
I don't believe this code should have been removed. Region() is used by non-chroot builders which do not have access to the metadata.
|
This is probably obsolete. I'll try to check. |
|
This has been osolete by later changes. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the instance metadata client originally introduced with the change from goamz to aws-sdk-go in favour of the one recently introduced to aws-sdk-go which supports retries.
This is as per the discussion on the original conversion from goamz at #2034.