hyperv: Add option to use legacy network adapter

[gh2k]

Add an option to allow hyperv to use a legacy network adapter instead of the default.

[gh2k]

I was trying to fix #4404 with this, but it turns out that this doesn't actually help matters. My belief that having a legacy adapter would correctly report the IP address was, I think, based on faulty tests.

Nevertheless I'll leave this open as it might benefit someone and it doesn't do any harm.

[mwhooker]

Thanks very much for this. I appreciate leaving the PR open, but I don't think we'll merge this right away unless it's requested. Untargeting

[taliesins]

Can we close this PR?

[mwhooker]

@taliesins up to you

[puneetloya]

Is there a plan to merge this to main packer?

[Justin-DynamicD]

it's odd that it doesn't help matters as it should (I can install ubuntu using a legacy adapter and not need integration drivers). While it may not "solve" the problem entirely I imagine it at least helps.

[matthew-hickok]

This would still be a great option to have.

[tuxillo]

Hi,

Why isn't this merged? It is not possible to use packer to build images of OSes that don't suport synthetic network adapters.

Before finding this PR I have done something similar (but much less elegant I think tuxillo@f67c265) and it's not reporting the IP back either, @gh2k did you figure out why?

Thanks,
Antonio Huete

[tuxillo]

The way the IP is retrieved in

packer/common/powershell/hyperv/hyperv.go

Line 979 in 92940ec

func IpAddress(mac string) (string, error) {

seems to return "" for legacy network adapters when the guest is not running integration services:

PS C:\Users\Administrator\go\bin> Hyper-V\Get-Vm | %{$_.NetworkAdapters}

Name                   IsManagementOs VMName SwitchName                                       MacAddress   Status IPAddresses
----                   -------------- ------ ----------                                       ----------   ------ -----
Legacy Network Adapter False          test   Red Hat VirtIO Ethernet Adapter - Virtual Switch 0155D792809 {Ok}   {}

I created the VM manually to test this, therefore it is not a replica, which is the only thing that would show an empty "IpAddresses" according to my google searches :)

Regards,
Antonio Huete

[SwampDragons]

Closing this due to old age and questions as to whether it ever worked. If someone wants to pick up development of this feature, I'll gladly review a new PR.

[tuxillo]

Hey wait, I'm still working on this! Sorry for the delay :)

[tuxillo]

All the work will likely happen in #5993, ignore my previous comment.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.