Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug while publishing SIG destination id for every managed image #7837

Merged
merged 1 commit into from Jul 8, 2019

Conversation

amydutta
Copy link
Contributor

@amydutta amydutta commented Jul 4, 2019

I have tested locally with managed image being published to Azure Shared Image Gallery and a managed image not being published to Azure Shared Image Gallery.

@SwampDragons This should unblock folks NOT publishing to Azure Shared Image Gallery who were running into errors.

@amydutta amydutta requested a review from paulmey as a code owner July 4, 2019 01:00
@paulmey
Copy link
Collaborator

paulmey commented Jul 4, 2019

So this fixes #7816 ?

Copy link
Collaborator

@paulmey paulmey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@SwampDragons SwampDragons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@flyinprogrammer
Copy link

Can confirm this patch seems to fix the EOFs that I saw, and were reported in #7816

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@hashicorp hashicorp locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants