Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug while publishing SIG destination id for every managed image #7837

Merged
merged 1 commit into from Jul 8, 2019

Conversation

@amydutta
Copy link
Contributor

commented Jul 4, 2019

I have tested locally with managed image being published to Azure Shared Image Gallery and a managed image not being published to Azure Shared Image Gallery.

@SwampDragons This should unblock folks NOT publishing to Azure Shared Image Gallery who were running into errors.

@amydutta amydutta requested a review from paulmey as a code owner Jul 4, 2019

@paulmey

This comment has been minimized.

Copy link
Collaborator

commented Jul 4, 2019

So this fixes #7816 ?

@paulmey
paulmey approved these changes Jul 4, 2019
Copy link
Collaborator

left a comment

Looks good to me

@SwampDragons
Copy link
Member

left a comment

Thanks for this!

@SwampDragons SwampDragons merged commit 8315da6 into hashicorp:master Jul 8, 2019

15 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_darwin Your tests passed on CircleCI!
Details
ci/circleci: build_freebsd Your tests passed on CircleCI!
Details
ci/circleci: build_linux Your tests passed on CircleCI!
Details
ci/circleci: build_openbsd Your tests passed on CircleCI!
Details
ci/circleci: build_solaris Your tests passed on CircleCI!
Details
ci/circleci: build_windows Your tests passed on CircleCI!
Details
ci/circleci: check-fmt Your tests passed on CircleCI!
Details
ci/circleci: check-generate Your tests passed on CircleCI!
Details
ci/circleci: check-vendor-vs-mod Your tests passed on CircleCI!
Details
ci/circleci: store_artifacts Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
license/cla Contributor License Agreement is signed.
Details

@SwampDragons SwampDragons added this to the 1.4.3 milestone Jul 8, 2019

@SwampDragons SwampDragons referenced this pull request Jul 16, 2019
@flyinprogrammer

This comment has been minimized.

Copy link

commented Aug 2, 2019

Can confirm this patch seems to fix the EOFs that I saw, and were reported in #7816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.