Fix Hyper-V boot command refs #9765
Conversation
|
|
There was a problem hiding this comment.
Hello there, thanks for the contribution; this LGTM; please sign the CLA so that we can merge this when is ready 🙂
I made a suggestion that could make it more simple. I think defining smaller chuck sizes e already possible through the driver
dreadknought
force-pushed
the
fix-hyperv-boot-command
branch
from
95c91ad
to
6bfe621
Compare
Codecov Report
|
|
Made the suggested change, thanks! |
|
Great and the checks are all green! Please sign the CLA so that we can merge this. |
There was a problem hiding this comment.
Hey there! I'm waiting for you to sing our CLA to merge this.
|
Hi @sylviamoss, I think there may be a problem with the CLA signing process, I've already signed it and when I visit the link to sign, it says it's signed. Screen shot here: |
The boot command was being sent as a single long string to be typed into the Hyper-V VM, which caused some scan codes to be intermittently skipped. The boot command is now split up and sent as chunks of 32 scan codes at a time. Closes hashicorp#5291
dreadknought
force-pushed
the
fix-hyperv-boot-command
branch
from
6bfe621
to
fd3296f
Compare
|
I found the problem with the signed CLA, user error on my part. Thanks. |
|
Nice!! Thank you! |
nywilken
changed the title
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
The boot command was being sent as a single long string to be
typed into the Hyper-V VM, which caused some scan codes to be
intermittently skipped. The boot command is now split up and sent as
chunks of 32 scan codes at a time.
Closes #5291