fix(Card): Refactor types for Card primitive (#820)

* fix(Card): Refactor types for Card primitive * chore: Add changeset
hashicorp · Nov 14, 2022 · 5009393 · 5009393 · vercel · Nov 14, 2022
1 parent 45fe15e
commit 5009393
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/.changeset/nine-items-boil.md b/.changeset/nine-items-boil.md
@@ -0,0 +1,5 @@
+---
+'@hashicorp/react-card': patch
+---
+
+Refactors Card primitive to use its own type. Fixes type errors stemming from children being set as a key on BaseCardProps.
diff --git a/packages/card/primitives.tsx b/packages/card/primitives.tsx
@@ -5,7 +5,7 @@ import Link from 'next/link'
 import ProductBadge from '@hashicorp/react-product-badge'
 import { IconArrowRight24 } from '@hashicorp/flight-icons/svg-react/arrow-right-24'
 import type {
-  BaseCardProps,
+  CardPrimitiveProps,
   ThumbnailProps,
   MetaProps,
   ContentProps,
@@ -15,7 +15,7 @@ import type {
 } from './types'
 import s from './style.module.css'
 
-const Card = React.forwardRef<HTMLAnchorElement, BaseCardProps>(
+const Card = React.forwardRef<HTMLAnchorElement, CardPrimitiveProps>(
   (props, ref) => {
     const {
       appearance = 'light',

diff --git a/packages/card/types.ts b/packages/card/types.ts
@@ -6,6 +6,9 @@ export interface BaseCardProps {
   withArrow?: boolean
   heading: string
   link: string
+}
+
+export interface CardPrimitiveProps extends BaseCardProps {
   children: React.ReactNode
 }