feat: remove formLeadInput support (#946)

hashicorp · May 2, 2023 · e99310f · e99310f · vercel · May 2, 2023
1 parent 9d34c38
commit e99310f
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 159 deletions.
diff --git a/.changeset/hungry-eagles-repeat.md b/.changeset/hungry-eagles-repeat.md
@@ -0,0 +1,5 @@
+---
+'@hashicorp/react-hero': major
+---
+
+Remove support for formLeadInput
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/hero/fragment.graphql b/packages/hero/fragment.graphql
@@ -45,10 +45,6 @@ fragment heroFields on HeroSectionRecord {
     external
     url
   }
-  formLeadInput {
-    destinationUrl
-    buttonText
-  }
   helpText(markdown: true)
   smallTextTag
   theme

diff --git a/packages/hero/heroLeadForm.js b/packages/hero/heroLeadForm.js
diff --git a/packages/hero/index.js b/packages/hero/index.js
@@ -11,7 +11,6 @@ import { eliminateOrphans } from '@hashicorp/js-utils'
 import useProductMeta from '@hashicorp/platform-product-meta'
 import VideoCarousel from './carousel'
 import ArrowIcon from './arrow-icon'
-import HeroLeadForm from './heroLeadForm'
 import fragment from './fragment.graphql'
 import s from './style.module.css'
 
@@ -25,7 +24,6 @@ function Hero({ data, centered, gaPrefix, className, videoControlsTop }) {
     backgroundTheme = 'dark',
     buttons,
     description,
-    formLeadInput,
     helpText,
     image,
     product,
@@ -97,19 +95,7 @@ function Hero({ data, centered, gaPrefix, className, videoControlsTop }) {
               }}
             />
           )}
-          {formLeadInput ? (
-            <div className={s.headlineFormLead}>
-              <HeroLeadForm
-                submitRedirectUrl={formLeadInput.destinationUrl}
-                buttonText={formLeadInput.buttonText}
-                theme={{
-                  background: backgroundTheme,
-                  brand: product,
-                  variant: 'primary',
-                }}
-              />
-            </div>
-          ) : buttons && buttons.length ? (
+          {buttons && buttons.length ? (
             <div
               className={classNames(s.headlineButtons, {
                 [s.centered]: isCentered,

diff --git a/packages/hero/index.test.js b/packages/hero/index.test.js
@@ -36,8 +36,6 @@ test.todo('renders the `backgroundImage` prop correctly')
 test.todo('renders the `smallTextTag` prop correctly')
 test.todo('renders the `titleLogo` prop correctly')
 test.todo('renders the `alert` prop correctly')
-test.todo('renders the `formLeadInput` prop correctly')
-test.todo('submits form data correctly from `formLeadInput`')
 test.todo('renders the `buttons` prop correctly')
 test.todo('renders the `helpText` prop correctly as text, html, or markdown')
 test.todo('renders the `videos` prop correctly')

diff --git a/packages/hero/package.json b/packages/hero/package.json
@@ -12,9 +12,7 @@
     "@hashicorp/react-alert": "^6.0.2",
     "@hashicorp/react-button": "^6.0.4",
     "@hashicorp/react-image": "^4.0.4",
-    "@hashicorp/react-text-input": "^5.0.1",
     "classnames": "^2.3.1",
-    "formik": "^2.2.9",
     "promise-polyfill": "^8.2.1",
     "query-string": "^6.14.1"
   },

diff --git a/packages/hero/props.js b/packages/hero/props.js
@@ -82,15 +82,6 @@ module.exports = {
           text: { type: 'string' },
         },
       },
-      formLeadInput: {
-        type: 'object',
-        description:
-          'A single-field form intended to capture emails, appears below the headline, description, and buttons',
-        properties: {
-          destinationUrl: { type: 'string' },
-          buttonText: { type: 'string' },
-        },
-      },
       buttons: {
         type: 'array',
         description:
@@ -158,15 +149,13 @@ module.exports = {
       backgroundTheme: 'dark',
       theme: 'nomad-green',
       backgroundImage: {
-        url:
-          'https://www.datocms-assets.com/2885/1538522323-vault-grid-background.jpg',
+        url: 'https://www.datocms-assets.com/2885/1538522323-vault-grid-background.jpg',
         format: 'svg',
         alt: 'terraform background',
       },
       smallTextTag: null,
       titleLogo: {
-        url:
-          'https://www.datocms-assets.com/2885/1512161155-terraform-color.svg',
+        url: 'https://www.datocms-assets.com/2885/1512161155-terraform-color.svg',
         format: 'svg',
         alt: 'terraform logo',
       },
@@ -176,7 +165,6 @@ module.exports = {
         tagColor: 'error-red',
         text: 'Some notification',
       },
-      formLeadInput: { destinationUrl: '#', buttonText: 'Submit' },
       buttons: [
         {
           title: 'Download',
@@ -208,8 +196,7 @@ module.exports = {
             },
             {
               srcType: 'mp4',
-              url:
-                '//consul-static-asssets.global.ssl.fastly.net/videos/v1/connect-video-ui.mp4',
+              url: '//consul-static-asssets.global.ssl.fastly.net/videos/v1/connect-video-ui.mp4',
             },
           ],
         },
@@ -218,8 +205,7 @@ module.exports = {
           src: [
             {
               srcType: 'mp4',
-              url:
-                '//consul-static-asssets.global.ssl.fastly.net/videos/v1/connect-video-cli.mp4',
+              url: '//consul-static-asssets.global.ssl.fastly.net/videos/v1/connect-video-cli.mp4',
             },
           ],
         },