fix(button): tweak small button padding to fix alignment in subnav (#397

)
hashicorp · Oct 18, 2021 · edcaf4f · edcaf4f · vercel · Oct 18, 2021
1 parent 9d70e6b
commit edcaf4f
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/.changeset/fuzzy-pumpkins-camp.md b/.changeset/fuzzy-pumpkins-camp.md
@@ -0,0 +1,5 @@
+---
+'@hashicorp/react-subnav': patch
+---
+
+Bump button dependency. Explicit changset added to enable canary pre-release.
diff --git a/.changeset/thick-sheep-return.md b/.changeset/thick-sheep-return.md
@@ -0,0 +1,5 @@
+---
+'@hashicorp/react-button': patch
+---
+
+Fixes a off-by-1px issue where small-size buttons were not the correct height. Targets specific alignment issue in react-subnav.
diff --git a/packages/button/theme.module.css b/packages/button/theme.module.css
@@ -6,7 +6,7 @@
   --border-color-hovered: var(--brand);
   --border-color: var(--brand);
   --padding-medium: 12px 20px;
-  --padding-small: 7px 20px 8px 20px;
+  --padding-small: 7px 20px 7px 20px;
   --scrim-color-active: rgba(0, 0, 0, 0.2);
   --scrim-color: rgba(0, 0, 0, 0.1);
   --scrim-opacity-active: 1;
@@ -69,7 +69,7 @@
   --border-color-hovered: transparent;
   --border-color: rgba(29, 30, 35, 0.2);
   --padding-medium: 12px 20px;
-  --padding-small: 7px 20px 8px 20px;
+  --padding-small: 7px 20px 7px 20px;
   --scrim-color-active: var(--black);
   --scrim-color: var(--black);
   --scrim-opacity-active: 0.16;