feat(card): Make date optional on <ResourceCard />
#1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dd8b04a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
EnMod
added
enhancement
📦 Canary Packages PublishedLatest commit: dd8b04a Published 2 packages@hashicorp/react-card@0.15.0-canary-20230926184001@hashicorp/react-related-content@0.3.8-canary-20230926184001 |
EnMod
requested review from
a team and
nandereck
and removed request for
a team
dstaley
reviewed
Sep 26, 2023
| @@ -31,4 +31,18 @@ describe('<ResourceCard />', () => { | |||
|
|
|||
| expect(metaElement).toContainElement(screen.getByText('|')) | |||
| }) | |||
|
|
|||
| it('should not render the date if no date is provided', () => { | |||
| defaultProps.date = '' | |||
There was a problem hiding this comment.
Instead of modifying default props, make a new object and spread defaultProps
const defaultPropsWithoutDate = { ...defaultProps, date: '' }
There was a problem hiding this comment.
Good call, addressed here:
dd8b04a
| const meta: string[] = [category] | ||
|
|
||
| if (date) { | ||
| meta.unshift(date) |
There was a problem hiding this comment.
Instead of mutating an array, let's use something like this:
const meta: string[] = date ? [date, category] : [category]There was a problem hiding this comment.
Ah, another good immutability catch 🚀 Addressed here:
dd8b04a
- Test: Spread default props into new object - meta assignment: use new arrays as values rather than mutating
EnMod
removed
the
release:canary
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Asana Task for request prompting the change
🔢 PR on
wwwimplementing the canary release🔍 Preview Link
🔍 Preview Link for example usage on
www(see each case study library item's card)Description
This PR updates our
<ResourceCard />component to make showing the date optional; if no date is passed in, no date (or|separator) is shown.PR Checklist 🚀
Items in this checklist may not may not apply to your PR, but please consider each item carefully.