Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add z-index to alert banner #1023

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

LeahMarieBush
Copy link
Contributor

@LeahMarieBush LeahMarieBush commented May 15, 2024

🎟️ Asana Task
πŸ” Preview Link


Description

This PR adds a z index to the alert banner component. This is to prevent an overlay blur on the alert banner from the subnav dropdowns.

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
react-components βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 15, 2024 6:28pm

Copy link

changeset-bot bot commented May 15, 2024

πŸ¦‹ Changeset detected

Latest commit: b18321f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-alert-banner Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LeahMarieBush LeahMarieBush marked this pull request as ready for review May 15, 2024 18:41
@LeahMarieBush LeahMarieBush requested review from a team and EnMod and removed request for a team May 15, 2024 18:41
Copy link
Contributor

@EnMod EnMod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeahMarieBush LeahMarieBush merged commit bb757d9 into main May 15, 2024
7 checks passed
@LeahMarieBush LeahMarieBush deleted the leah/fix/alert-banner-z-index branch May 15, 2024 20:29
@hashibot-web hashibot-web mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants