Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alert banner styling #1026

Merged
merged 2 commits into from
May 21, 2024
Merged

fix: alert banner styling #1026

merged 2 commits into from
May 21, 2024

Conversation

LeahMarieBush
Copy link
Contributor

@LeahMarieBush LeahMarieBush commented May 21, 2024

🔍 Preview Link


Description

This PR fixes some styling bugs for the alert banner. When I was testing previously, I just used the preview link since the canary release was failing. Now that the token has been updated, I tested using the canary release and it looks as expected.

PR Checklist 🚀

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 7:31pm

Copy link

changeset-bot bot commented May 21, 2024

🦋 Changeset detected

Latest commit: f4e8af2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-alert-banner Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LeahMarieBush LeahMarieBush added the release:canary Triggers a canary release for commits to this pull request label May 21, 2024
Copy link
Contributor

📦 Canary Packages Published

Latest commit: f4e8af2

Published 1 packages

@hashicorp/react-alert-banner@7.3.1-canary-20240521193225

npm install @hashicorp/react-alert-banner@canary

@LeahMarieBush LeahMarieBush changed the title Leah/fix/alert banner style fix: alert banner styling May 21, 2024
@LeahMarieBush LeahMarieBush marked this pull request as ready for review May 21, 2024 19:49
@LeahMarieBush LeahMarieBush requested review from a team and dstaley and removed request for a team May 21, 2024 19:49
@LeahMarieBush LeahMarieBush merged commit a648ded into main May 21, 2024
8 checks passed
@LeahMarieBush LeahMarieBush deleted the leah/fix/alert-banner-style branch May 21, 2024 20:52
@hashibot-web hashibot-web mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:canary Triggers a canary release for commits to this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants