Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content-cta)!: convert to CSS modules #306

Merged
merged 3 commits into from Sep 7, 2021
Merged

Conversation

zchsh
Copy link
Contributor

@zchsh zchsh commented Aug 28, 2021

🎟️ Asana Task
πŸ” Preview Link


This PR updates @hashicorp/react-content-cta to use CSS modules.

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2021

πŸ¦‹ Changeset detected

Latest commit: 656b21e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-content-cta Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/hashicorp/react-components/8ZzwMaZpLWQFepno2EPxUf58mSi4
βœ… Preview: https://react-components-git-zscontent-cta-css-modules-hashicorp.vercel.app

Base automatically changed from zs.button-css-modules to main August 31, 2021 14:46
@@ -1,51 +0,0 @@
import React from 'react'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was some old Storybook content here which is no longer relevant, so removed it πŸ”ͺ

@@ -11,7 +11,6 @@
@import '../packages/product-features-list/style.css';
@import '../packages/enterprise-alert/style.css';
@import '../packages/featured-slider/style.css';
@import '../packages/content-cta/style.css';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ”ͺ πŸŽ‰

@zchsh zchsh marked this pull request as ready for review September 3, 2021 20:29
@zchsh zchsh requested a review from a team September 3, 2021 20:29
@zchsh zchsh merged commit 1eceec6 into main Sep 7, 2021
@zchsh zchsh deleted the zs.content-cta-css-modules branch September 7, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants