Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sentinel-embedded): trigger publish for deps update #367

Merged
merged 1 commit into from Feb 1, 2022

Conversation

BRKalow
Copy link
Contributor

@BRKalow BRKalow commented Sep 30, 2021

🎟️ Asana Task
πŸ” Preview Link


Description

It turns out, patch version ranges are very restrictive when you're on 0.0.x

Screen Shot 2021-09-30 at 10 09 09 AM

npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: sentinel-docs@1.0.0
npm ERR! Found: @hashicorp/sentinel-embedded@0.0.14
npm ERR! node_modules/@hashicorp/sentinel-embedded
npm ERR!   @hashicorp/sentinel-embedded@"0.0.14" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @hashicorp/sentinel-embedded@"^0.0.9" from @hashicorp/react-sentinel-embedded@1.0.3
npm ERR! node_modules/@hashicorp/react-sentinel-embedded
npm ERR!   @hashicorp/react-sentinel-embedded@"1.0.3" from the root project

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@vercel
Copy link

vercel bot commented Sep 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/hashicorp/react-components/CTEY58DLKsJrdwfrkqHM3pzu3VCV
βœ… Preview: https://react-components-git-brkchore-publish-sentinte-d5cd73-hashicorp.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2021

πŸ¦‹ Changeset detected

Latest commit: 077a8cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-sentinel-embedded Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BRKalow BRKalow requested a review from a team December 22, 2021 14:55
Copy link
Contributor

@zchsh zchsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

βœ… Ugh TIL πŸ’– .... and I guess doing like @hashicorp/sentinel-embedded: 0 would probably be way too optimistic / brittle πŸ˜…

I for one am confused how it is that https://registry.npmjs.org/@hashicorp/react-sentinel-embedded is showing the current 1.0.3 version of react-sentinel-embedded but with the ^0.0.9 dep, while we're already showing ^0.0.14... +1 that this seems like the right way to fix, anyways πŸ‘

@BRKalow BRKalow merged commit 9e64fa1 into main Feb 1, 2022
@BRKalow BRKalow deleted the brk.chore/publish-sentintel-embedded branch February 1, 2022 22:24
@github-actions github-actions bot mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants