Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade markdown-utils dep #393

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Conversation

kendallstrautman
Copy link
Contributor

@kendallstrautman kendallstrautman commented Oct 12, 2021

🎟️ Asana Task
πŸ” Preview Link


Description

This PR upgrades the @hashicorp/markdown-utils dep to pull in changes for the updated remark plugin with an a11y fix.

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2021

πŸ¦‹ Changeset detected

Latest commit: 8e23a8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hashicorp/react-docs-page Patch
@hashicorp/react-markdown-page Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/hashicorp/react-components/JAwrQb6yhkxxRKHXSSNSbSdFaGiN
βœ… Preview: https://react-components-git-ksupgrade-markdown-utils-hashicorp.vercel.app

@kendallstrautman
Copy link
Contributor Author

Are we cool to use npm v7 in this library yet?

@jescalan
Copy link
Contributor

Yes we are!

@kendallstrautman kendallstrautman merged commit 950f79c into main Oct 13, 2021
@kendallstrautman kendallstrautman deleted the ks.upgrade-markdown-utils branch October 13, 2021 17:34
@github-actions github-actions bot mentioned this pull request Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants