Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select-input): safely access value for key #405

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

BRKalow
Copy link
Contributor

@BRKalow BRKalow commented Oct 19, 2021

🎟️ Asana Task
πŸ” Preview Link


Description

Describe this pull request: what is it aiming to achieve? What should someone reviewing this PR know? If this PR includes visual changes, consider including before / after screenshots, or an animated gif showing interactions.

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@vercel
Copy link

vercel bot commented Oct 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/hashicorp/react-components/2WgY3K9WQsdfMr4mDf3KRx91jmvc
βœ… Preview: https://react-components-git-brkfix-select-input-key-hashicorp.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2021

πŸ¦‹ Changeset detected

Latest commit: 6937d55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-select-input Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BRKalow BRKalow added the release:canary Triggers a canary release for commits to this pull request label Oct 19, 2021
@github-actions
Copy link
Contributor

πŸ“¦ Canary Packages Published

Latest commit: 6937d55

Published 3 packages

@hashicorp/react-docs-page@14.4.5-canary-202191918515

npm install @hashicorp/react-docs-page@canary

@hashicorp/react-open-api-page@2.0.1-canary-202191918515

npm install @hashicorp/react-open-api-page@canary

@hashicorp/react-select-input@4.0.5-canary-202191918515

npm install @hashicorp/react-select-input@canary

Copy link
Contributor

@alexcarpenter alexcarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the issue we were seeing in www builds πŸ‘πŸΌ

@BRKalow BRKalow merged commit aa4fd98 into main Oct 19, 2021
@BRKalow BRKalow deleted the brk.fix/select-input-key branch October 19, 2021 21:15
@github-actions github-actions bot mentioned this pull request Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:canary Triggers a canary release for commits to this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants