Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enforced left-alignment for table headers #490

Merged
merged 1 commit into from Jan 14, 2022
Merged

Conversation

dstaley
Copy link
Contributor

@dstaley dstaley commented Jan 14, 2022

🎟️ Asana Task
πŸ” Preview Link


Description

This removes the default text-align: left; rule for table headers, allowing authors to align their headers whichever way sparks joy. By default, table headers will now be center aligned.

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@vercel
Copy link

vercel bot commented Jan 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/hashicorp/react-components/Bi6Jbnp29mrqYbM5eB6XsvgzC6cH
βœ… Preview: https://react-components-git-dsth-no-left-align-hashicorp.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2022

πŸ¦‹ Changeset detected

Latest commit: d58c090

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-content Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dstaley dstaley changed the title remove enforced left-alignment for table headers Remove enforced left-alignment for table headers Jan 14, 2022
@dstaley dstaley merged commit d545b9d into main Jan 14, 2022
@dstaley dstaley deleted the ds.th-no-left-align branch January 14, 2022 20:36
@github-actions github-actions bot mentioned this pull request Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant