Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-page): bumps docs-mdx for code-block fix #504

Merged
merged 4 commits into from
Feb 23, 2022
Merged

Conversation

zchsh
Copy link
Contributor

@zchsh zchsh commented Jan 28, 2022

🎟️ Asana Task
πŸ” Preview Link


This PR bumps the @hashicorp/platform-docs-mdx dependency in @hashicorp/react-docs-page in order to pull in a fix for a Firefox-specific manual copy-and-paste issue, as described and fixed in #503.

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@zchsh zchsh added the release:canary Triggers a canary release for commits to this pull request label Jan 28, 2022
@vercel
Copy link

vercel bot commented Jan 28, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/hashicorp/react-components/4D9kztzCMjJ8fwQgA9zJSLN7pCpj
βœ… Preview: https://react-components-git-zsbump-docs-page-mdx-hashicorp.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2022

πŸ¦‹ Changeset detected

Latest commit: 33c8551

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-docs-page Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2022

πŸ“¦ Canary Packages Published

Latest commit: 33c8551

Published 1 packages

@hashicorp/react-docs-page@14.14.3-canary-20220223214927

npm install @hashicorp/react-docs-page@canary

@zchsh
Copy link
Contributor Author

zchsh commented Feb 23, 2022

(Sorry for the noise there, meant to request on hashicorp/web-platform-packages#18 - I'll need to merge and publish that work, bump to stable docs-mdx here, and THEN this will be actually ready for review)

@zchsh
Copy link
Contributor Author

zchsh commented Feb 23, 2022

@BRKalow this is a follow-on to hashicorp/web-platform-packages#18 πŸ‘

Copy link
Contributor

@BRKalow BRKalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸš‚

@zchsh zchsh changed the title fix(docs-page): bumps docs-mdx to fix manual code-block copy issue fix(docs-page): bumps docs-mdx for code-block fix Feb 23, 2022
@zchsh zchsh merged commit 25d353c into main Feb 23, 2022
@zchsh zchsh deleted the zs.bump-docs-page-mdx branch February 23, 2022 21:53
@github-actions github-actions bot mentioned this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:canary Triggers a canary release for commits to this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants