Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs-page): wrap docs page content with CodeTabsProvider #508

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

BRKalow
Copy link
Contributor

@BRKalow BRKalow commented Feb 15, 2022

🎟️ Asana Task
πŸ” Preview Link


Description

Wrap the content rendered by DocsPage in CodeTabsProvider to ensure that tab syncing can function across multiple instances of CodeTabs.

Validated here: https://vault-git-brkfeat-code-tabs-sync-hashicorp.vercel.app/docs/get-started/developer-qs

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2022

πŸ¦‹ Changeset detected

Latest commit: f423473

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-docs-page Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 15, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/hashicorp/react-components/9H35BxR2U3RK6ARr2redKnUVmHDu
βœ… Preview: https://react-components-git-brkfeat-code-tabs-provide-7d8165-hashicorp.vercel.app

@BRKalow BRKalow added the release:canary Triggers a canary release for commits to this pull request label Feb 15, 2022
@github-actions
Copy link
Contributor

πŸ“¦ Canary Packages Published

Latest commit: f423473

Published 1 packages

@hashicorp/react-docs-page@14.14.2-canary-20220215211727

npm install @hashicorp/react-docs-page@canary

@BRKalow BRKalow requested a review from a team February 15, 2022 21:22
@BRKalow BRKalow merged commit f0bfe27 into main Feb 15, 2022
@BRKalow BRKalow deleted the brk.feat/code-tabs-provider-docs-page branch February 15, 2022 22:06
@github-actions github-actions bot mentioned this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:canary Triggers a canary release for commits to this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants