Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs-page): add optInBanner prop to docs-page #597

Merged
merged 2 commits into from
May 26, 2022

Conversation

BRKalow
Copy link
Contributor

@BRKalow BRKalow commented May 24, 2022

🎟️ Asana Task
πŸ” Preview Link


Description

Adds an optInBanner prop to docs page so we can render an opt-in banner for dev portal. Intentionally made the prop specific as we'll eventually be pulling this code into dev-portal and or deprecating it, so it doesn't make sense to try and make this a "generic" feature.

Related dev-portal PR: hashicorp/dev-portal#470

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@BRKalow BRKalow added the release:canary Triggers a canary release for commits to this pull request label May 24, 2022
@changeset-bot
Copy link

changeset-bot bot commented May 24, 2022

πŸ¦‹ Changeset detected

Latest commit: 55c4bf9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-docs-page Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 24, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
react-components βœ… Ready (Inspect) Visit Preview May 24, 2022 at 9:54PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2022

πŸ“¦ Canary Packages Published

Latest commit: 55c4bf9

Published 3 packages

@hashicorp/react-docs-page@16.2.0-canary-20220524215628

npm install @hashicorp/react-docs-page@canary

@hashicorp/react-notification@0.2.0-canary-20220524215628

npm install @hashicorp/react-notification@canary

@hashicorp/react-toast@0.1.2-canary-20220524215628

npm install @hashicorp/react-toast@canary

@BRKalow BRKalow requested a review from a team May 25, 2022 15:09
Copy link
Contributor

@BrandonRomano BrandonRomano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BRKalow BRKalow merged commit b2c0228 into main May 26, 2022
@BRKalow BRKalow deleted the brk.feat/docs-page-opt-in-banner branch May 26, 2022 13:14
@hashibot-web hashibot-web mentioned this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:canary Triggers a canary release for commits to this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants