Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Bump mktg-logos to v1.3.2 #740

Merged
merged 4 commits into from Oct 4, 2022
Merged

Conversation

nandereck
Copy link
Contributor

@nandereck nandereck commented Oct 4, 2022

🎟️ Asana Task
πŸ” Preview Link


Description

It was recently discovered that the old Vault logo is currently being used in the Subnav component. This PR updates packages so as to use the new logos (logo change here).

Validation Steps

  • Navigate to the Subnav in Preview
  • Set text in the titleLink prop to HashiCorp Vault
  • Verify that the correct logo is displayed:

Screen Shot 2022-10-04 at 9 31 16 AM

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2022

πŸ¦‹ Changeset detected

Latest commit: 19f37c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-subnav Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 4, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
react-components βœ… Ready (Inspect) Visit Preview Oct 4, 2022 at 9:16PM (UTC)

Copy link
Contributor

@alexcarpenter alexcarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you wan to test a canary release to 100% verify in dev portal before merging here?

@alexcarpenter alexcarpenter added the release:canary Triggers a canary release for commits to this pull request label Oct 4, 2022
@nandereck
Copy link
Contributor Author

LGTM. Do you wan to test a canary release to 100% verify in dev portal before merging here?

Wasn't sure how best to test on dev portal. I'll do that. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

πŸ“¦ Canary Packages Published

Latest commit: 19f37c8

Published 1 packages

@hashicorp/react-subnav@9.5.0-canary-20221004211658

npm install @hashicorp/react-subnav@canary

@nandereck
Copy link
Contributor Author

@alexcarpenter - confirmed this does the trick. Mind giving this one more look?

Copy link
Contributor

@alexcarpenter alexcarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need an npm i to fix the package-lock.json conflict, but approving!

@nandereck nandereck merged commit ea84007 into main Oct 4, 2022
@nandereck nandereck deleted the nels/chores/bump-mktg-logos branch October 4, 2022 21:18
@hashibot-web hashibot-web mentioned this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:canary Triggers a canary release for commits to this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants