New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Bump mktg-logos
to v1.3.2
#740
Conversation
π¦ Changeset detectedLatest commit: 19f37c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do you wan to test a canary release to 100% verify in dev portal before merging here?
Wasn't sure how best to test on dev portal. I'll do that. Thanks! |
π¦ Canary Packages PublishedLatest commit: 19f37c8 Published 1 packages@hashicorp/react-subnav@9.5.0-canary-20221004211658
|
@alexcarpenter - confirmed this does the trick. Mind giving this one more look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might need an npm i
to fix the package-lock.json conflict, but approving!
ecd1edb
to
19f37c8
Compare
ποΈ Asana Task
π Preview Link
Description
It was recently discovered that the old Vault logo is currently being used in the
Subnav
component. This PR updates packages so as to use the new logos (logo change here).Validation Steps
Subnav
in Previewtext
in thetitleLink
prop toHashiCorp Vault
PR Checklist π
Items in this checklist may not may not apply to your PR, but please consider each item carefully.