Enable `StandaloneLink` in `Actions` #758

nandereck · 2022-10-12T05:25:10Z

🎟️ Asana Task
🔍 Preview Link
🎨 Figma

Description

This PR adds support for the StandaloneLink in Actions. The requirements are as follows:

Actions supports all of the Button / StandaloneLink combinations in the spec.
The first CTA and second CTA are always the primary variation and secondary variation respectively.
When both a Button and StandaloneLink render, the StandaloneLink always comes second.
Addition

The changeset includes the following:

Adds StandaloneLink to the render method of Actions
Changes the url prop for Actions to href. This was done to match the <a> attribute name.
Removes the now cruft variant prop from CTAs in Actions
Updates the docs and tests to account for the new variations
Updates failing tests for Intro and NextSteps. This occurs due to the change of the url prop to href

Validation Steps

Navigate to Actions in the preview
Under examples, verify that all of the variations match the Figma (see above)

PR Checklist 🚀

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

Add Asana and Preview links above.
Conduct thorough self-review.
Add or update tests as appropriate.
Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

vercel · 2022-10-12T05:25:13Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
react-components	✅ Ready (Inspect)	Visit Preview	Oct 14, 2022 at 7:57PM (UTC)

changeset-bot · 2022-10-12T05:25:13Z

🦋 Changeset detected

Latest commit: 7250da9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@hashicorp/react-actions	Minor
@hashicorp/react-intro	Minor
@hashicorp/react-next-steps	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nandereck · 2022-10-12T05:40:31Z

@alexcarpenter - WIP PR here. Curious to get your thoughts on this.

I think this hits all the requirements (see the description above), is relatively understandable, and is backwards compatible with the existing Actions component.

There's also a high likelihood that I'm overlooking something important here too 😅 🙃

packages/actions/types.ts

packages/actions/index.tsx

packages/actions/types.ts

packages/actions/index.tsx

packages/actions/types.ts

packages/actions/index.tsx

nandereck · 2022-10-13T20:00:01Z

Cool - @alexcarpenter I think this is ready for re-review.

github-actions · 2022-10-13T20:01:51Z

📦 Canary Packages Published

Latest commit: 7250da9

Published 3 packages

@hashicorp/react-actions@0.4.0-canary-20221014205736

npm install @hashicorp/react-actions@canary

@hashicorp/react-intro@0.5.0-canary-20221014205736

npm install @hashicorp/react-intro@canary

@hashicorp/react-next-steps@0.3.0-canary-20221014205736

npm install @hashicorp/react-next-steps@canary

alexcarpenter

LGTM. A couple of little cleanup things we can do before merging.

Update props.js to fix brand -> theme. This was my mistake when initially building this out. and I don't think variant is available on the ctas, its type right?

This reverts commit 8f09662.

This reverts commit fa24ae3.

alexcarpenter

LGTM! Nice work. 👏🏼

@nandereck

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @hashicorp/react-actions@0.4.0 ### Minor Changes - [#758](#758) [`f464318c`](f464318) Thanks [@nandereck](https://github.com/nandereck)! - Enables StandaloneLink support in Actions. Updates NextSteps and Intro components to accommodate changes in Actions. ## @hashicorp/react-intro@0.5.0 ### Minor Changes - [#758](#758) [`f464318c`](f464318) Thanks [@nandereck](https://github.com/nandereck)! - Enables StandaloneLink support in Actions. Updates NextSteps and Intro components to accommodate changes in Actions. ### Patch Changes - Updated dependencies \[[`f464318c`](f464318)]: - @hashicorp/react-actions@0.4.0 ## @hashicorp/react-next-steps@0.3.0 ### Minor Changes - [#758](#758) [`f464318c`](f464318) Thanks [@nandereck](https://github.com/nandereck)! - Enables StandaloneLink support in Actions. Updates NextSteps and Intro components to accommodate changes in Actions. ### Patch Changes - Updated dependencies \[[`f464318c`](f464318)]: - @hashicorp/react-actions@0.4.0 - @hashicorp/react-intro@0.5.0

nandereck changed the title ~~Nels/intro/add standalone link support v3~~ Enable StandaloneLink in Actions Oct 12, 2022

nandereck changed the title ~~Enable StandaloneLink in Actions~~ Enable StandaloneLink in Actions (WIP) Oct 12, 2022

nandereck commented Oct 12, 2022

View reviewed changes

packages/actions/types.ts Outdated Show resolved Hide resolved

nandereck commented Oct 12, 2022

View reviewed changes

packages/actions/index.tsx Outdated Show resolved Hide resolved

alexcarpenter reviewed Oct 12, 2022

View reviewed changes

packages/actions/index.tsx Outdated Show resolved Hide resolved

packages/actions/index.tsx Outdated Show resolved Hide resolved

packages/actions/types.ts Outdated Show resolved Hide resolved

alexcarpenter reviewed Oct 12, 2022

View reviewed changes

packages/actions/index.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview October 12, 2022 16:59 View deployment

vercel bot deployed to Preview October 12, 2022 17:45 View deployment

nandereck commented Oct 12, 2022

View reviewed changes

packages/actions/types.ts Outdated Show resolved Hide resolved

vercel bot deployed to Preview October 12, 2022 17:47 View deployment

vercel bot deployed to Preview October 12, 2022 18:16 View deployment

vercel bot deployed to Preview October 12, 2022 18:25 View deployment

nandereck commented Oct 12, 2022

View reviewed changes

packages/actions/index.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview October 12, 2022 22:51 View deployment

vercel bot deployed to Preview October 12, 2022 23:42 View deployment

vercel bot deployed to Preview October 12, 2022 23:53 View deployment

vercel bot deployed to Preview October 13, 2022 19:29 View deployment

nandereck added the release:canary Triggers a canary release for commits to this pull request label Oct 13, 2022

vercel bot deployed to Preview October 13, 2022 19:52 View deployment

nandereck changed the title ~~Enable StandaloneLink in Actions (WIP)~~ Enable StandaloneLink in Actions Oct 13, 2022

nandereck requested a review from alexcarpenter October 13, 2022 19:59

vercel bot deployed to Preview October 13, 2022 20:00 View deployment

alexcarpenter reviewed Oct 13, 2022

View reviewed changes

vercel bot deployed to Preview October 13, 2022 20:58 View deployment

vercel bot deployed to Preview October 13, 2022 21:09 View deployment

nandereck added 21 commits October 14, 2022 12:55

update package-lock

cfeea4b

rm cruft comment

6f76ce1

update url references to href

aa69647

rm variant

85de605

add tests

a2e9459

add key

63e1f10

update nextsteps and intro tests

743d247

add tests to account for different combinations

653d3d9

add changeset

2066366

update docs

6e7f74f

update docs

8c7cd82

Revert "add changeset"

a245b0e

This reverts commit 8f09662.

Revert "update nextsteps and intro tests"

588b39d

This reverts commit fa24ae3.

revert package-lock.json

11ee1c7

update package-lock.json

11e8ecf

add changeset

78620df

update intro

4fd5cb9

update next-steps

99fa721

add new changeset

669b291

rm old changeset

f41f2c3

update intro test

7250da9

nandereck force-pushed the nels/intro/add-standalone-link-support-v3 branch from f32c90b to 7250da9 Compare October 14, 2022 19:55

vercel bot deployed to Preview October 14, 2022 19:57 View deployment

alexcarpenter approved these changes Oct 14, 2022

View reviewed changes

nandereck added release:canary Triggers a canary release for commits to this pull request and removed release:canary Triggers a canary release for commits to this pull request labels Oct 14, 2022

nandereck merged commit f464318 into main Oct 14, 2022

nandereck deleted the nels/intro/add-standalone-link-support-v3 branch October 14, 2022 21:31

hashibot-web mentioned this pull request Oct 14, 2022

Version Packages #765

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable `StandaloneLink` in `Actions` #758

Enable `StandaloneLink` in `Actions` #758

nandereck commented Oct 12, 2022 •

edited

Loading

vercel bot commented Oct 12, 2022 •

edited

Loading

changeset-bot bot commented Oct 12, 2022 •

edited

Loading

nandereck commented Oct 12, 2022

nandereck commented Oct 13, 2022

github-actions bot commented Oct 13, 2022 •

edited

Loading

@hashicorp/react-actions@0.4.0-canary-20221014205736

@hashicorp/react-intro@0.5.0-canary-20221014205736

@hashicorp/react-next-steps@0.3.0-canary-20221014205736

alexcarpenter left a comment

alexcarpenter left a comment

Enable StandaloneLink in Actions #758

Enable StandaloneLink in Actions #758

Conversation

nandereck commented Oct 12, 2022 • edited Loading

Description

Validation Steps

PR Checklist 🚀

vercel bot commented Oct 12, 2022 • edited Loading

changeset-bot bot commented Oct 12, 2022 • edited Loading

🦋 Changeset detected

nandereck commented Oct 12, 2022

nandereck commented Oct 13, 2022

github-actions bot commented Oct 13, 2022 • edited Loading

📦 Canary Packages Published

@hashicorp/react-actions@0.4.0-canary-20221014205736

@hashicorp/react-intro@0.5.0-canary-20221014205736

@hashicorp/react-next-steps@0.3.0-canary-20221014205736

alexcarpenter left a comment

Choose a reason for hiding this comment

alexcarpenter left a comment

Choose a reason for hiding this comment

Enable `StandaloneLink` in `Actions` #758

Enable `StandaloneLink` in `Actions` #758

nandereck commented Oct 12, 2022 •

edited

Loading

vercel bot commented Oct 12, 2022 •

edited

Loading

changeset-bot bot commented Oct 12, 2022 •

edited

Loading

github-actions bot commented Oct 13, 2022 •

edited

Loading