Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace <StandaloneLink /> with anchor element in <RelatedContent /> #845

Merged
merged 4 commits into from
Dec 13, 2022

Conversation

nandereck
Copy link
Contributor

@nandereck nandereck commented Dec 9, 2022

🎟️ Asana Task
πŸ” Preview Link


Description

When <RelatedContent /> was created, it used the <StandaloneLink /> component for a CTA. However, the WPL spec for <RelatedContent /> does not utilize <StandaloneLink /> and instead uses its own, custom link.

This PR removes the <StandaloneLink /> and adds an anchor element.

Validation Steps

  • Navigate to the preview
  • Verify that the CTA link matches the spec for light and dark:

Screen Shot 2022-12-09 at 11 33 52 AM

Screen Shot 2022-12-09 at 11 33 55 AM

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@vercel
Copy link

vercel bot commented Dec 9, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
react-components βœ… Ready (Inspect) Visit Preview Dec 13, 2022 at 4:48AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2022

πŸ¦‹ Changeset detected

Latest commit: 54265c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-related-content Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nandereck nandereck marked this pull request as ready for review December 9, 2022 19:37
@nandereck nandereck requested a review from a team December 13, 2022 01:03
@nandereck nandereck merged commit 4734c65 into main Dec 13, 2022
@nandereck nandereck deleted the na.update-relatedcontent branch December 13, 2022 17:33
@hashibot-web hashibot-web mentioned this pull request Dec 13, 2022
nandereck pushed a commit that referenced this pull request Dec 13, 2022
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

# Releases
## @hashicorp/react-related-content@0.3.0

### Minor Changes

-   [#845](#845) [`4734c654`](4734c65) Thanks [@nandereck](https://github.com/nandereck)! - Replace StandaloneLink with custom link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants