update(react-card): dark mode colors #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b4b36c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pbortnick
added
the
release:canary
📦 Canary Packages PublishedLatest commit: b4b36c9 Published 2 packages@hashicorp/react-card@0.13.0-canary-20230811213229@hashicorp/react-related-content@0.3.6-canary-20230811213229 |
6 tasks
Moving away from a 'expected token as variable, value as fallback' approach, in favor of a 'value used directly, design token in comment' approach. Ref: https://hashicorp.slack.com/archives/C031LA4KS4S/p1691774993436509?thread_ts=1691762754.792629&cid=C031LA4KS4S
dstaley
approved these changes
Aug 11, 2023
Co-authored-by: Dylan Staley <88163+dstaley@users.noreply.github.com>
EnMod
removed
the
release:canary
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Discussion
🔍 Preview Link
Description
(EDIT By @EnMod:) This PR updates the colors of dark appearance
<Card />components to match our new spec, using new tokens. Prompted by a Vercel thread on using new colors for cards on an upcoming project (discussion thread linked above). Design has approved of the look/feel.PR Checklist 🚀
Items in this checklist may not may not apply to your PR, but please consider each item carefully.