feat(inline video): add videoClassName prop
#993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: ac7d356 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pbortnick
requested review from
a team and
nandereck
and removed request for
a team
|
Out of curiosity, what are the style changes to the |
@nandereck we have a video who's thumbnail is mostly white making it blend into a white background. We want to apply these styles to give it some dimension |
Oh, cool that makes sense! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Asana Task
🔍 Preview Link
Description
This PR adds the optional
videoClassNameprop so that we can add custom styles that may be needed, such as border, box shadows, etc.This is related to some updates being made to the dotcom about page.
PR Checklist 🚀
Items in this checklist may not may not apply to your PR, but please consider each item carefully.