Clean up downloaded assets after verification and install #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downstream actions, such as `goreleaser/goreleaser-action` expect the workspace directory to be clean, otherwise an error is thrown:
```
• starting release...
• loading path=.goreleaser.yml
• loading environment variables
• using token from $GITHUB_TOKEN
• getting and validating git state
• git state commit=ae346ceb6430b05e78d73a47b3975658f43ffa50 branch=HEAD current_tag=v2.4.2 previous_tag=v2.4.1 dirty=true
⨯ release failed after 0s error=git is in a dirty state
Please check in your pipeline what can be changing the following files:
?? hc-releases_0.1.15_SHA256SUMS
?? hc-releases_0.1.15_linux_amd64.zip
Learn more at https://goreleaser.com/errors/dirty
```
shore
requested changes
Jan 23, 2024
scripts/setup-hc-releases.sh
Outdated
| @@ -55,7 +55,6 @@ sums_name="hc-releases_${version}_SHA256SUMS" | |||
| echo "Installing release $version" | |||
|
|
|||
| # download | |||
| /bin/rm -vf "$sums_name" "hc-releases_${version}_${pattern}" # remove in case they already exist from previous invocation | |||
There was a problem hiding this comment.
This is still needed unless the gh release download ... commands below get --clobber.
(When this was written, self-hosted runners had an older version of gh that didn't support --clobber and jobs that used the action twice would fail to download the second time around.)
bflad
added a commit
to hashicorp/ghaction-terraform-provider-release
that referenced
this pull request
Jan 23, 2024
bflad
added a commit
to hashicorp/ghaction-terraform-provider-release
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream actions, such as
goreleaser/goreleaser-actionexpect the workspace directory to be clean, otherwise an error is thrown: