This repository has been archived by the owner on Dec 6, 2023. It is now read-only.
Add cut list item to link override #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
didoo
reviewed
Aug 29, 2023
| @@ -65,7 +65,7 @@ $underline-width: 1px; | |||
|
|
|||
| @mixin apply { | |||
| /* [debug] #{$_module}@apply */ | |||
| :any-link:not(.pds-button, #{overrides.$hds-link-overrides-selectors}) { | |||
| :any-link:not(.pds-button, .cut-list-item > a.cut-list-item__content-container, #{overrides.$hds-link-overrides-selectors}) { | |||
There was a problem hiding this comment.
What do you think of introducing a new variable $cut-link-overrides-selectors in the overrides file https://github.com/hashicorp/structure/blob/d00c8bf39c22b5490a4c6fa8bae951b934432dfb/packages/pds-ember/app/styles/pds/_overrides.scss and use that instead, as generic "container"? In this way you can have a better control (also in the future) of the selectors in Cloud UI, adding your variable there too:
- https://github.com/hashicorp/cloud-ui/blob/main/addons/core/addon/styles/_overrides.scss#L35
- https://github.com/hashicorp/cloud-ui/blob/main/engines/boundary/tests/dummy/app/styles/hcp/_overrides.scss#L35 (probably this is not needed, for your overrides)
There was a problem hiding this comment.
@didoo great thinking 👍
3 tasks
|
I've update this to add |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the consul ui toolkit list item to the any-link override.
Before:
After applying the class manually:
