Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support provider defined functions for Terraform HCL #99

Merged
merged 5 commits into from
Feb 22, 2024
Merged

feat: support provider defined functions for Terraform HCL #99

merged 5 commits into from
Feb 22, 2024

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Feb 15, 2024 •
edited
Loading

This adds support for provider defined functions (e.g. provider::framework::example("hi")) to the Terraform HCL syntax.

Resolves #98

ansgarm
ansgarm commented Feb 15, 2024
View reviewed changes
src/terraform.yml Outdated Show resolved Hide resolved
@ansgarm ansgarm marked this pull request as ready for review February 16, 2024 08:06
@ansgarm ansgarm requested a review from a team as a code owner February 16, 2024 08:06
dbanck
dbanck reviewed Feb 19, 2024
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left some comments

src/terraform.yml Outdated Show resolved Hide resolved
src/terraform.yml Outdated Show resolved Hide resolved
src/terraform.yml Outdated Show resolved Hide resolved
tests/snapshot/terraform/expressions_functions.tf.snap Outdated Show resolved Hide resolved
@ansgarm ansgarm force-pushed the support-tf-provider-defined-fns branch from b86f4f0 to 1b110a7 Compare February 19, 2024 16:16
@ansgarm ansgarm force-pushed the support-tf-provider-defined-fns branch from 2dc1969 to 3659378 Compare February 20, 2024 14:44
@ansgarm ansgarm requested a review from dbanck February 20, 2024 14:45
dbanck
dbanck reviewed Feb 21, 2024
View reviewed changes
src/terraform.yml Outdated Show resolved Hide resolved
@ansgarm ansgarm mentioned this pull request Feb 21, 2024
Closed
11 tasks
@ansgarm
fix: allow true, false, and null in provider and function name of pro…
c98a17f 
…vider defined functions to reflect Terraforms constraints on these
@ansgarm ansgarm requested a review from dbanck February 22, 2024 08:10
dbanck
dbanck approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only a minor suggestions

src/terraform.yml Outdated Show resolved Hide resolved
@ansgarm @dbanck
chore: make regex more readable by replacing negation with the opposite
b8a932a 
Co-authored-by: Daniel Banck <dbanck@users.noreply.github.com>
@ansgarm ansgarm force-pushed the support-tf-provider-defined-fns branch from 014d3a8 to b8a932a Compare February 22, 2024 10:39
@ansgarm ansgarm merged commit 1141ac7 into main Feb 22, 2024
3 checks passed
@ansgarm ansgarm deleted the support-tf-provider-defined-fns branch February 22, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanck dbanck dbanck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support provider-defined functions syntax
2 participants
@ansgarm @dbanck