Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Replace backtick in run-vault with single quote #120

Merged

Conversation

briandbecker
Copy link
Contributor

  • Backticks causing unexpected behavior
  • Removes backticks in favor of single quote to match other items in the
    list
  • Credit to @BonzTM in Feature/ddb backend #77 for initially finding/fixing; isolated to get
    fix merged

* Backticks causing unexpected behavior
* Removes backticks in favor of single quote to match other items in the
  list
* Credit to @BonzTM in hashicorp#77 for initially finding/fixing; isolated to get
  fix merged
Copy link
Collaborator

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, good catch! I wonder how this hadn't caused issues before?

I'll merge now and let the tests run. If they pass, I'll issue a new release. Thanks!

@brikis98 brikis98 merged commit 39ee7db into hashicorp:master Dec 10, 2018
@briandbecker
Copy link
Contributor Author

@brikis98 any visibility into why the tests are failing? Locally it seems related to the enterprise vault being embedded into the tests.

@brikis98
Copy link
Collaborator

Build info is here: https://circleci.com/gh/hashicorp/terraform-aws-vault/215

@Etiene Any idea what this test failure is all about? Specific log file is at https://215-103201301-gh.circle-artifacts.com/0/tmp/logs/TestMainVaultCluster.log. Relevant part seems to be:

        			Error Trace:	vault_helpers.go:136
        			            				vault_cluster_enterprise_test.go:60
        			            				test_structure.go:24
        			            				asm_amd64.s:509
        			            				panic.go:366
        			            				testing.go:544
        			            				testing.go:582
        			            				retry.go:56
        			            				vault_helpers.go:398
        			            				vault_helpers.go:233
        			            				vault_cluster_enterprise_test.go:131
        			            				vault_cluster_enterprise_test.go:76
        			            				test_structure.go:24
        			            				vault_cluster_enterprise_test.go:72
        			            				vault_main_test.go:131
        			Error:      	"map[i-0e9f6fdd1fa5ac7d8:map[/opt/vault/log/vault-stdout.log:Error loading configuration from /opt/vault/config: error loading "/opt/vault/config/default.hcl": error parsing 'seal': 1 error occurred:
        			            	
        			            	* seal.awskms: invalid key "endpoint" on line 5
        			            	Error loading configuration from /opt/vault/config: error loading "/opt/vault/config/default.hcl": error parsing 'seal': 1 error occurred:
        			            	
        			            	* seal.awskms: invalid key "endpoint" on line 5
        			            	Error loading configuration from /opt/vault/config: error loading "/opt/vault/config/default.hcl": error parsing 'seal': 1 error occurred:
        			            	
        			            	* seal.awskms: invalid key "endpoint" on line 5
        			            	Error loading configuration from /opt/vault/config: error loading "/opt/vault/config/default.hcl": error parsing 'seal': 1 error occurred:
        			            	
        			            	* seal.awskms: invalid key "endpoint" on line 5
        			            	 /opt/vault/log/vault-error.log: /var/log/syslog:Dec 10 16:26:51 ip-172-31-21-17 rsyslogd: [origin software="rsyslogd" swVersion="8.16.0" x-pid="1049" x-info="http://www.rsyslog.com"] start
        			            	Dec 10 16:26:51 ip-172-31-21-17 rsyslogd-2222: command 'KLogPermitNonKernelFacility' is currently not permitted - did you already set it via a RainerScript command (v6+ config)? [v8.16.0 try http://www.rsyslog.com/e/2222 ]
        			            	Dec 10 16:26:51 ip-172-31-21-17 rsyslogd: rsyslogd's groupid changed to 108

@briandbecker
Copy link
Contributor Author

The change introduced in #117 added the endpoint attribute to the config; but this is only available in Vault OSS 1.0.0 and Enterprise. Perhaps the config entry for endpoint wasn't supported in enterprise?

Based on hashicorp/vault@3d1f0d7 it seems endpoint may be a new feature.

@brikis98
Copy link
Collaborator

@briandbecker That might be the case! @Etiene worked on that stuff and will take a look once she frees up.

@Etiene
Copy link
Contributor

Etiene commented Dec 17, 2018

@briandbecker you are correct! thanks for catching this. I'm adding a fix in PR #122

@brikis98 brikis98 mentioned this pull request Dec 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants