This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
enable auto join for consul clients #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for the PR! I'm super booked this week, but will try to take a look in the next few days. |
brikis98
reviewed
May 25, 2020
There was a problem hiding this comment.
We add the IAM policies from Consul as follows: https://github.com/hashicorp/terraform-aws-vault/blob/master/main.tf#L92-L96. Since this is Consul-specific, it seems to me that it makes more sense to do it that way?
|
Ah, actually thats what I was attempting to add, did not notice it was already in that other module. I'll close this PR thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consul seems to be the standard backend for this vault module, but cloud auto join is not supported currently because the IAM policies attached to the vault ec2 roles do not include the required permissions. I've just copied these from the terraform-aws-consul module, though Consul itself claims it only needs the ec2:DescribeInstances permission set.
Tested as follows: Currently using this PR branch in place of the current master module in my own project, and cloud auto_join is working as expected.