Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow action to work at airtight runners #178

Closed
1 task done
Hi-Fi opened this issue Apr 26, 2024 · 1 comment · Fixed by #179
Closed
1 task done

Allow action to work at airtight runners #178

Hi-Fi opened this issue Apr 26, 2024 · 1 comment · Fixed by #179
Labels
enhancement New feature or request new A new issue or feature request that has not yet been triaged by maintainers

Comments

@Hi-Fi
Copy link
Contributor

Hi-Fi commented Apr 26, 2024

Description

Currently action wants to always download Terraform (https://github.com/hashicorp/terraform-cdk-action/blob/main/src/action.ts#L79) as a blocking operation, and would fail if download is not possible.

We have Github Enterprise Server with self-hosted, mostly airtight runners that have tools pre-installed and packages available through internal repositories.

Event there wouldn't be airtight runners, downloading Terraform every time would not probably be desired option but "force" the used version and including it in the runner itself.

I see kind of 2 options how this could be done with small changes:

  • boolean value to disable download fully. Version info doesn't matter here
  • check if Terraform is installed already (and it's version). If that matches the configured one use it silently.

Third option would be to allow giving download host/URI (before package name/version) so that internal repository could be used as a source.

References

No response

Help Wanted

  • I'm interested in contributing a fix myself

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@Hi-Fi Hi-Fi added enhancement New feature or request new A new issue or feature request that has not yet been triaged by maintainers labels Apr 26, 2024
@Hi-Fi Hi-Fi mentioned this issue Apr 27, 2024
Merged
6 tasks
DanielMSchmidt pushed a commit that referenced this issue May 6, 2024
@Hi-Fi
feat: use preinstalled Terraform if available with specific version (#…
1ee9030 
…179)

<!--

Unless this is a very simple 1-line-of-code change, please create a new
issue describing the change you're proposing first, then link to it from
this PR.

Read more about our process in our contributing guide:
https://github.com/hashicorp/terraform-cdk-action/blob/main/.github/CONTRIBUTING.md

-->

### Related issue

Fixes #178 

### Description

Action will check availability of Terraform in PATH with version
configured to action. If there's suitable version available, it doesn't
download Terraform.

### Checklist

- [x] I have updated the PR title to match [CDKTF's style
guide](https://github.com/hashicorp/terraform-cdk-action/blob/main/.github/CONTRIBUTING.md#pull-requests-1)
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works if applicable
- [x] New and existing unit tests pass locally with my changes

<!-- If this is still a work in progress, feel free to open a draft PR
until you're able to check off all the items on the list above -->
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

I'm going to lock this issue because it has been closed for at least 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue so we can investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request new A new issue or feature request that has not yet been triaged by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use preinstalled Terraform if available with specific version Hi-Fi/terraform-cdk-action
1 participant
@Hi-Fi