feat(cli): namespace aws provider #1101
Conversation
packages/cdktf-cli/lib/get/generator/constants/provider-namespaces.ts
Outdated
Show resolved
Hide resolved
packages/cdktf-cli/lib/get/generator/constants/provider-namespaces.ts
Outdated
Show resolved
Hide resolved
DanielMSchmidt
force-pushed
the
submodules-for-aws-provider
branch
4 times, most recently
from
2e595e3
to
19409ed
Compare
There was a problem hiding this comment.
@DanielMSchmidt How did you get the list and all of the prefixes? At a glance they look correct, but would take awhile to verify all of them.
We should try to confirm if this fixes the python ide issues.
May also want to check the impact on provider generation time.
packages/cdktf-cli/lib/get/generator/constants/provider-namespaces.ts
Outdated
Show resolved
Hide resolved
DanielMSchmidt
force-pushed
the
submodules-for-aws-provider
branch
3 times, most recently
from
7b4bc63
to
4d83850
Compare
|
@jsteinich I went through the AWS provider by hand trying to be very diligent |
DanielMSchmidt
force-pushed
the
submodules-for-aws-provider
branch
3 times, most recently
from
be7faac
to
283247a
Compare
Yes, good points - we should confirm this 👍 |
DanielMSchmidt
force-pushed
the
submodules-for-aws-provider
branch
3 times, most recently
from
253e918
to
cacb08f
Compare
This change splits up the AWS providers into submodules, which we expect to speed up compile time on other languages and help with compilation issues when adding more classes / function exports per file Closes #572 BREAKING CHANGE: This changes the API surface of big providers and will require manual fixes for the imports e.g. aws.Route53Record becomes aws.Route53.Record
This allows us to host core logic in one place and consume it both here and in the @cdktf/hcl2cdk package
DanielMSchmidt
force-pushed
the
submodules-for-aws-provider
branch
from
cacb08f
to
5397ed4
Compare
packages/@cdktf/provider-generator/lib/get/generator/constants/provider-namespaces.ts
Outdated
Show resolved
Hide resolved
packages/@cdktf/provider-generator/lib/get/generator/constants/provider-namespaces.ts
Show resolved
Hide resolved
packages/@cdktf/provider-generator/lib/get/generator/provider-generator.ts
Outdated
Show resolved
Hide resolved
packages/@cdktf/provider-generator/lib/get/generator/provider-generator.ts
Show resolved
Hide resolved
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This change splits up the AWS providers into submodules, which we expect to speed up compile time on other languages and help with compilation issues when adding more classes / function exports per file
Closes #572
BREAKING CHANGE: This changes the API surface of big providers and will require manual fixes for the imports e.g. aws.Route53Record becomes aws.Route53.Record
This is an alternative approach to #1083