Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interpolation bug in complex computed list of data sources #215

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

jooohn
Copy link
Contributor

@jooohn jooohn commented Jul 20, 2020

Interpolation of ComplexComputedList for TerraformDataSources should starts with data. prefix.

@hashicorp-cla
Copy link

hashicorp-cla commented Jul 20, 2020

CLA assistant check
All committers have signed the CLA.

@skorfmann
Copy link
Contributor

Thanks for your contribution, very appreciated. It looks good at a first glance. Could you provide a pointer to the provider schema and the resource where you encountered this issue?

@jooohn
Copy link
Contributor Author

jooohn commented Jul 20, 2020

@skorfmann

I've encountered this issue when tried this data source attribute.

https://www.terraform.io/docs/providers/aws/d/organizations_organization.html#roots

@anubhavmishra
Copy link
Member

@skorfmann should be good to merge?

@skorfmann skorfmann merged commit 4c00f2b into hashicorp:master Jul 20, 2020
@skorfmann
Copy link
Contributor

@jooohn thanks again for your contribution. You can use it via cdktf@next until there's a proper release.

@jooohn
Copy link
Contributor Author

jooohn commented Jul 20, 2020

thank you for approving this!

@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants