Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Terraform Version Check #216

Closed
skorfmann opened this issue Jul 20, 2020 · 5 comments
Closed

Add Terraform Version Check #216

skorfmann opened this issue Jul 20, 2020 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@skorfmann
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Reduce confusion to users running an older version of Terraform by printing out a warning notice when Terraform < 0.12

The functionality could also be useful when new versions of Terraform are being released (e.g. 0.13 with the changed provider naming schema).

References

#208

@skorfmann skorfmann added the enhancement New feature or request label Jul 20, 2020
@skorfmann skorfmann added the good first issue Good for newcomers label Aug 25, 2020
@bverhoeve
Copy link
Contributor

Hi @skorfmann I'm looking to contribute to the repository, what exactly needs to be done?

@skorfmann
Copy link
Contributor Author

Hi @skorfmann I'm looking to contribute to the repository, what exactly needs to be done?

For the case where a user uses something below 0.12, it would be great to display a clear error message and exit the process. The supported Terraform versions at the moment are 0.12 and 0.13. I think the check should go like this:

  • < SUPPORTED => exit with error message
  • >= SUPPORTED => continue without further message.

We do have a terraform check already, which checks for the presence of the Terraform CLI only. This could be expanded to check against supported versions and print a helpful error message.


ps: I was thinking about if it would make sense to print a warning when a user is using > SUPPORTED (e.g. alpha of 0.14 at the moment). However, I think it's not important for now and I'd ignore this case until we actually run into issues with a case like that.

@bverhoeve
Copy link
Contributor

Okay, thanks for the explanation! I'll check to tend to it.

@skorfmann
Copy link
Contributor Author

This was addressed in #378

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants