Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle Provider Compatibility #341

Merged
merged 2 commits into from Aug 26, 2020
Merged

Oracle Provider Compatibility #341

merged 2 commits into from Aug 26, 2020

Conversation

skorfmann
Copy link
Contributor

There's a function in the Oracle provider which is named nodeMetadata. This conflicts
with function in cdktf base classes.

Hence, this PR aligins the naming with the change from node to constructNode (see #230)

Fixes #290

There's a function in the Oracle provider which is named `nodeMetadata`. This conflicts
with function in cdktf base classes.

Hence, this PR aligins the naming with the change from `node` to `constructNode` (see #230)

Fixes #290
@skorfmann skorfmann merged commit 76da576 into master Aug 26, 2020
@skorfmann skorfmann deleted the oracle-provider-fix branch August 26, 2020 08:17
Copy link
Member

@anubhavmishra anubhavmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@skorfmann skorfmann mentioned this pull request Aug 31, 2020
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oracle Provider Generates Invalid Classes
2 participants