Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop custom symlink for generic plugin cache setting #344

Merged
merged 10 commits into from Aug 31, 2020
Merged

Conversation

skorfmann
Copy link
Contributor

@skorfmann skorfmann commented Aug 24, 2020

Since the current symlink approach for caching poviders has multiple
drawbacks, this PR switches to the general plugin cache dir supported
by Terraform directly.

https://www.terraform.io/docs/commands/cli-config.html#provider-plugin-cache

Fixes #189
Fixes #222
Fixes #349

Since the current symlink approach for caching poviders has multiple
drawbacks, this PR switches to the general plugin cache dir supported
by Terraform directly.

https://www.terraform.io/docs/commands/cli-config.html#provider-plugin-cache

Fixes #189
Fixes #222
@skorfmann
Copy link
Contributor Author

Looks like lots of parallel provider downloads and TF_PLUGIN_CACHE_DIR aren't working well together - I know I had similar issues with Terragrunt in another project.

Perhaps we could think about adding all used providers to the Docker image in advance - Or have one bootstrap step where all used providers are fetched sequentially.

@skorfmann
Copy link
Contributor Author

Again, it'd be pretty helpful to have the Docker image published automatically (#36) /cc @anubhavmishra

This is primarily useful when configuring the plugin cache via terraform.rc
or similar means
Copy link
Member

@anubhavmishra anubhavmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add a note in the docs to show that we are setting the TF_PLUGIN_CACHE_DIR environment variable.

skorfmann and others added 5 commits August 27, 2020 10:39
Co-authored-by: Anubhav Mishra <anubhavmishra@users.noreply.github.com>
Co-authored-by: Anubhav Mishra <anubhavmishra@users.noreply.github.com>
@skorfmann
Copy link
Contributor Author

We can add a note in the docs to show that we are setting the TF_PLUGIN_CACHE_DIR environment variable.

Done

@skorfmann skorfmann merged commit f27aa64 into master Aug 31, 2020
@skorfmann skorfmann deleted the no-symlink branch August 31, 2020 14:55
@skorfmann skorfmann mentioned this pull request Aug 31, 2020
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants