New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop custom symlink for generic plugin cache setting #344
Conversation
Since the current symlink approach for caching poviders has multiple drawbacks, this PR switches to the general plugin cache dir supported by Terraform directly. https://www.terraform.io/docs/commands/cli-config.html#provider-plugin-cache Fixes #189 Fixes #222
Looks like lots of parallel provider downloads and Perhaps we could think about adding all used providers to the Docker image in advance - Or have one bootstrap step where all used providers are fetched sequentially. |
Again, it'd be pretty helpful to have the Docker image published automatically (#36) /cc @anubhavmishra |
This is primarily useful when configuring the plugin cache via terraform.rc or similar means
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add a note in the docs to show that we are setting the TF_PLUGIN_CACHE_DIR
environment variable.
Co-authored-by: Anubhav Mishra <anubhavmishra@users.noreply.github.com>
Co-authored-by: Anubhav Mishra <anubhavmishra@users.noreply.github.com>
Done |
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Since the current symlink approach for caching poviders has multiple
drawbacks, this PR switches to the general plugin cache dir supported
by Terraform directly.
https://www.terraform.io/docs/commands/cli-config.html#provider-plugin-cache
Fixes #189
Fixes #222
Fixes #349