Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): hcl render fails in false(bool), 0(int), ""(str) value #3626

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(cli): hcl render fails in false(bool), 0(int), ""(str) value #3626

wants to merge 4 commits into from
+17 −7

Conversation

tenminus11
Copy link

@tenminus11 tenminus11 commented May 19, 2024 •
edited

…tring

Related issue

Fixes #3621

Description

In plain English, describe your approach to addressing the issue linked above. For example, if you made a particular design decision, let us know why you chose this path instead of another solution.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@tenminus11 tenminus11 requested a review from a team as a code owner May 19, 2024 10:58
@tenminus11 tenminus11 requested review from mutahhir and ansgarm and removed request for a team May 19, 2024 10:58
@hashicorp-cla-app HashiCorp CLA App
Copy link

hashicorp-cla-app bot commented May 19, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@hashicorp-cla-app HashiCorp CLA App
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@tenminus11 tenminus11 changed the title fix(hcl render): add false value in hcl module which returned empty s… fix(cli): hcl render fails in false(bool), 0(int), ""(str) value May 27, 2024
@tenminus11
Copy link
Author

@hashicorp/cdktf requesting to review this PR and suggested code

@DanielMSchmidt
Copy link
Contributor

Hey, thanks for the help! Could you add a test case or two so we don't reintroduce the problem in the future?

@tenminus11
Copy link
Author

Hi @DanielMSchmidt
I have little understanding of terraform-cdk codebase, surrounding toolchain and also access to it
It would be best if someone who has worked on this project to add test cases and do other checks
I am fine with others using this code as reference and extend with changes and test cases to fix this issue as whole

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutahhir mutahhir Awaiting requested review from mutahhir mutahhir is a code owner automatically assigned from hashicorp/cdktf

@ansgarm ansgarm Awaiting requested review from ansgarm ansgarm is a code owner automatically assigned from hashicorp/cdktf

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cdktf: synth --hcl fails to render false(bool), 0(int), ""(empty string)
2 participants
@tenminus11 @DanielMSchmidt