Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depends on expansion #442

Merged
merged 2 commits into from
Nov 26, 2020
Merged

Conversation

jsteinich
Copy link
Collaborator

Fixes #369

Allows for depends on to specify resources, data sources, or modules.
Modules allowed to depend on the same.

Module dependencies were added in Terraform 0.13. We could add an error if running below that, but seems fine to just let Terraform fail.

Copy link
Contributor

@skorfmann skorfmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool - looks good. Please resolve the merge conflict.

Module dependencies were added in Terraform 0.13. We could add an error if running below that, but seems fine to just let Terraform fail.

Yes, that's good.

@skorfmann skorfmann merged commit 4c2bd1a into hashicorp:master Nov 26, 2020
@skorfmann skorfmann mentioned this pull request Dec 4, 2020
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depends On Data Sources
2 participants