Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject defaults for certain attributes #479

Merged
merged 3 commits into from
Feb 5, 2021

Conversation

jsteinich
Copy link
Collaborator

@jsteinich jsteinich commented Jan 9, 2021

Fixes #234
Fixes #223
Fixes #443

Simple default values injected during code generation based on fully qualified attribute name.
Currently not allowing users to specify their own defaults, but could expose through cdktf.json if that was desired.
Specifying individual attributes rather than whole block for a bit more flexibility, but could switch that.

@jsteinich
Copy link
Collaborator Author

@skorfmann Should I go ahead and other other known resources in the same manner?

@skorfmann
Copy link
Contributor

Currently not allowing users to specify their own defaults, but could expose through cdktf.json if that was desired.

I think that's mostly a stop-gap solution, so not sure what users would need to inject here. It's certainly good enough for a first iteration.

Specifying individual attributes rather than whole block for a bit more flexibility, but could switch that.

Makes sense 👍

Should I go ahead and other other known resources in the same manner?

Yes, please :)

Base automatically changed from master to main January 29, 2021 14:09
@jsteinich jsteinich marked this pull request as ready for review January 31, 2021 15:01
@skorfmann skorfmann merged commit dc72801 into hashicorp:main Feb 5, 2021
@skorfmann skorfmann mentioned this pull request Mar 11, 2021
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants