Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsii-srcmak to remove symlink #580

Merged
merged 2 commits into from
Feb 24, 2021

Conversation

jsteinich
Copy link
Collaborator

Fixes #501 (or at least a portion of it).

@jsteinich
Copy link
Collaborator Author

Looks like the first test run failed because of maven concurrency issues.

I'll mark not draft once I test on Windows.

@skorfmann
Copy link
Contributor

Looks like the first test run failed because of maven concurrency issues.

Yeah, I saw this in the other PRs as well. We'll have to run them sequentially for now.

@jsteinich jsteinich marked this pull request as ready for review February 23, 2021 14:35
Copy link
Contributor

@skorfmann skorfmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, here's the fix cdklabs/jsii-srcmak#307

@skorfmann skorfmann merged commit 666c32a into hashicorp:main Feb 24, 2021
@skorfmann skorfmann mentioned this pull request Mar 11, 2021
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C# cdktf get fails on windows, symlink
2 participants