Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename null provider for java & c# #589

Merged
merged 3 commits into from
Mar 5, 2021

Conversation

jsteinich
Copy link
Collaborator

Fixes #588

null is not allowed to be a namespace in java or c#, so replace it.

packages/cdktf-cli/lib/get/base.ts Outdated Show resolved Hide resolved
packages/cdktf-cli/lib/get/base.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@skorfmann skorfmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! :)

@skorfmann skorfmann merged commit 3e1db05 into hashicorp:main Mar 5, 2021
@skorfmann skorfmann mentioned this pull request Mar 11, 2021
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null provider generates java code in package import.null
2 participants