Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Terraform versions which are tested against #592

Merged
merged 6 commits into from
Mar 11, 2021

Conversation

skorfmann
Copy link
Contributor

This drops tests against 0.12 in favour of testing against the upcoming 0.15 version. That means with this PR being merged we're testing against 0.13, 0.14, and 0.15-beta.

This depends #591 and will help #584 being merged. There are some provider schema differences with the change from 0.12 to 0.13 which don't seem worthwhile working around (I think it's purely testing related, functionality wise it's not an issue).

I think it generally makes sense for now to track the current and prior major release of Terraform core - plus upcoming versions.

@danieldreier
Copy link
Contributor

Do we check what TF version a user is using? My gut feel here is that we should at least warn people, if not error out, if they are using an older version we don't test against

@skorfmann
Copy link
Contributor Author

Do we check what TF version a user is using? My gut feel here is that we should at least warn people, if not error out, if they are using an older version we don't test against

That's a good point and yes, we do check for the Terraform version and error out. For prior 0.12 it just didn't work at all, that's why we errored out there. Happy to continue with that strict handling though - so, how about bumping the check up to 0.13 then?

Technically, versions like `0.12` might still work. So, I think
for the time being it's ok to print the warning only. If we see
an increase in support issues around this, we should reconsider
@skorfmann
Copy link
Contributor Author

Went with a warning only for now - see 2f1cc9a

Screenshot 2021-03-11 at 10 13 35

@skorfmann skorfmann merged commit 6c3ceb1 into main Mar 11, 2021
@skorfmann skorfmann deleted the update-terraform-versions branch March 11, 2021 09:31
@skorfmann skorfmann mentioned this pull request Mar 11, 2021
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants