Handle terraform init flags removed in 0.15 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
approved these changes
Jan 15, 2021
| args = append(args, "-verify-plugins="+fmt.Sprint(c.verifyPlugins)) | ||
|
|
||
| // boolean opts removed in 0.15: pass if <0.15 | ||
| err = tf.compatible(ctx, nil, tf0_15_0) |
There was a problem hiding this comment.
Nitpick: Should we also gate these flags on the other end (minimum version), similar to how we gate fmt?
There was a problem hiding this comment.
Yes, added #121 as it's a somewhat bigger job to go through and find the minimum versions for all flags, which might as well be done all at once. Merging this PR now so we can see if the next nightly passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the Terraform 0.15 CHANGELOG:
-lockand-lock-timeoutoptions are no longer available onterraform init[GH-27464]-verify-plugins=falseoption is no longer available onterraform init. (Terraform now always verifies plugins.) [GH-27461]-get-plugins=falseoption is no longer available onterraform init. (Terraform now always installs plugins.) [GH-27463]This PR adds a compatibility error if the user attempts to set these options when using Terraform 0.15 and above. We maintain the existing behaviour of passing default values for these options prior to 0.15.
This fixes the errors seen in the nightly
mastertest run (example).