This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
fix(run-consul): datacenter param in consul config #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be better to rename the function to |
darkslategrey
force-pushed
the
feature/regional-datacenter
branch
from
d456258
to
94cf616
Compare
…ad of Zone Datacenter: 'europe-west1' instead of 'europe-west1-b'
darkslategrey
force-pushed
the
feature/regional-datacenter
branch
from
94cf616
to
4373533
Compare
|
Thanks for this PR! As I mentioned in #19 (comment), this change will work for both single-zone and multi-zonal Instance Groups, so it LGTM and I'll merge now! Fixes #19. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datacenter will be for example 'europe-west1' instead of 'europe-west1-b'