textDocument/complete: Use isIncomplete for >100 items #132
Conversation
radeksimko
force-pushed
the
f-is-incomplete
branch
from
a289251
to
ac690f1
Compare
| candidates: make([]CompletionCandidate, 0), | ||
| } | ||
|
|
||
| prefix := prefixAtPos(file, pos) | ||
| for name, t := range bTypes { | ||
| if len(list.candidates) >= p.maxCandidates { |
There was a problem hiding this comment.
if the list was exactly max candidates, I think this is a minor bug?
There was a problem hiding this comment.
I think that's correct, it's just probably slightly more difficult to read/understand, because it's checking the length with the addition from the previous iteration.
If the length is equal to max then this conditional doesn't even get executed, because we reached the end of the slice. I will add one more test to cover this scenario.
radeksimko
force-pushed
the
f-is-incomplete
branch
from
ac690f1
to
1241c12
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
ghost
locked and limited conversation to collaborators
Closes #12
Ideally we should probably be limiting the number of items we pull out from whatever data storage, but the data is currently just schema and the schema is currently stored in memory, so it's cheap to just pull out everything and then cut it while constructing the completion list 🤷
We can revisit later.