jobs: Don't wait for GetModuleDataFromRegistry job
#1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
approved these changes
Jul 28, 2023
This job may make an HTTP request, and we schedule it in the low-priority queue, so we don't want to wait for it.
dbanck
force-pushed
the
f-avoid-module-wait
branch
from
5d0cada
to
253f277
Compare
This was referenced Aug 15, 2023
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This job may make an HTTP request and we schedule it in the low priority queue so we don't want to wait for it.
This can significantly reduce the request time for the
didOpenanddidChangecalls.Before
After
Another improvement might be not to schedule this job if there are no external module calls in a file.