Early validation #1368
Merged
Early validation #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanck
force-pushed
the
f-early-validation
branch
2 times, most recently
from
b5b251f
to
18ff8f8
Compare
This was referenced Sep 4, 2023
Merged
radeksimko
force-pushed
the
f-early-validation
branch
from
18ff8f8
to
372dbd5
Compare
radeksimko
force-pushed
the
f-early-validation
branch
from
44106bb
to
f6c6100
Compare
dbanck
force-pushed
the
f-early-validation
branch
from
f6c6100
to
468764c
Compare
This was referenced Sep 8, 2023
radeksimko
force-pushed
the
f-early-validation
branch
from
0712aed
to
9853098
Compare
dbanck
force-pushed
the
f-early-validation
branch
from
12031e3
to
74c8ab4
Compare
radeksimko
force-pushed
the
f-early-validation
branch
3 times, most recently
from
f5a17fe
to
7b6cfdf
Compare
radeksimko
force-pushed
the
f-early-validation
branch
from
3a95a63
to
1ab1358
Compare
dbanck
force-pushed
the
f-early-validation
branch
from
74c039c
to
d2f348e
Compare
Adds `validation.earlyValidation` as a new setting. I chose to use `validation` as a primary key as we expect to add future settings for this feature.
* Implement unreferenced variable validation (#1357) Add the ability to use the collected origin and target references in early validation by providing a hook for validation funcs. This also adds a validator for unreferenced variables. Validation funcs will be provided by terraform-ls for now, but may be moved into hcl-lang in the future. * Introduce ValidationDiagnostics field to module * Publish early validation diagnostics * Include validation diagnotics in changes check * Introduce early validation job * Check ValidationDiagnosticsState when running validation * Run early validation job after collection jobs * Bump hcl-lang to `b6a3f8` * Update internal/terraform/module/module_ops.go Co-authored-by: Radek Simko <radek.simko@gmail.com> --------- Co-authored-by: James Pogran <jpogran@outlook.com> Co-authored-by: Radek Simko <radek.simko@gmail.com>
* Introduce different source for diagnostics * Add reference validation job * Run terraform validate as a job * Track validation job states * Review feedback * Pass pathCtx to reference validation funcs * Rename early validation job * Bump hcl-lang to `29034e` * Introduce VarsDiagnosticsState * Fix tests
* Introduce new context for valiation settings * Check context before scheduling jobs
* validations: Limit ref. validation to only LocalOrigin(s) * validations: add test for disabled origins
* validations: Enable reference validation of locals * Update internal/decoder/validations/unreferenced_origin.go Co-authored-by: Daniel Banck <dbanck@users.noreply.github.com> * fix imports --------- Co-authored-by: Daniel Banck <dbanck@users.noreply.github.com>
* deps: bump hcl-lang to aa9b38d (#1414) * re-define decoupled validators
* Move everything into defer * Add comment about lsctx * Have module registry job depend on module metadata
dbanck
force-pushed
the
f-early-validation
branch
from
e775554
to
060b88e
Compare
This was referenced Oct 24, 2023
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the feature branch back into
main