terraform: Support 0.13 version #149
Conversation
This relaxes the version constraints as we now know where to find the lock file in 0.13+. This also enables support for any 0.12 prereleases.
|
|
||
| // Assume that alpha/beta/rc prereleases have the same compatibility | ||
| segments := rawVer.Segments64() | ||
| segmentsOnly := fmt.Sprintf("%d.%d.%d", segments[0], segments[1], segments[2]) |
There was a problem hiding this comment.
Perhaps it would be useful to upstream these two lines into go-version as Version.RawVersion() or something like that. Not something I'd want to block this PR on, but thinking out loud.
There was a problem hiding this comment.
Yeah, I think we should just start implementing this in terraform-exec and see what feels right there. I'd rather not have to have a lot of this stuff in different packages we need to think/worry about and terraform-exec will handle schema dumping, we could also add lock file watching to it, etc.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This relaxes the version constraints as we now know where to find the lock file in 0.13+.
This also enables support for any 0.12 prereleases.
Closes #111
I removed the upper bound constraint from the watcher as I reckon/hope that the lock file location won't change - and if it does, then the worst case scenario is that we will report the workspace as uninitialised.
I assume we may start constraining the parser at some point, but that's a problem for another day.