Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TokenTypeCapsule to TokenTypeComplex #1529

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Dec 19, 2023

This renames the existing token type TokenTypeCapsule to TokenTypeComplex to aid readability and reflect existing naming conventions.

This token represents list in type = list(string) and similar, i.e. the name of the complex type. The term "capsule" has slightly different meaning in cty and HCL and we should not use it in this context.

Pending hashicorp/hcl-lang#352

@jpogran jpogran self-assigned this Dec 19, 2023
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is still a draft but just FYI we'll also need to update the docs here

This renames the existing token type TokenTypeCapsule to TokenTypeComplex to aid readability and reflect existing naming conventions.

This token represents `list` in `type = list(string)` and similar, i.e. the name of the complex type. The term "capsule" has slightly different meaning in cty and HCL and we should not use it in this context.
@jpogran jpogran marked this pull request as ready for review December 20, 2023 15:41
@jpogran jpogran requested a review from a team as a code owner December 20, 2023 15:41
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would you mind also drafting a PR in vscode-terraform, just to ensure we don't forget about it, prior to merging?

@jpogran
Copy link
Contributor Author

jpogran commented Dec 20, 2023

LGTM, but would you mind also drafting a PR in vscode-terraform, just to ensure we don't forget about it, prior to merging?

Already prepped, waiting for this to merge

@radeksimko
Copy link
Member

I can't see the PR in the list but I'm happy as long as you confirmed that it's in the queue and you confirmed it's working on the client. 😄

Feel free to merge then.

@dbanck dbanck merged commit 2c21095 into main Dec 22, 2023
22 checks passed
@dbanck dbanck deleted the rename_token_type_capsule branch December 22, 2023 13:56
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants